]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: lan743x: reject unsupported external timestamp requests
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 12 Mar 2025 22:15:52 +0000 (15:15 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 20 Mar 2025 07:50:03 +0000 (08:50 +0100)
The lan743x_ptp_io_event_cap_en() function checks that the given request
sets only one of PTP_RISING_EDGE or PTP_FALLING_EDGE, but not both.

However, this driver does not check whether other flags (such as
PTP_EXT_OFF) are set, nor whether any future unrecognized flags are set.

Fix this by adding the appropriate check to the lan743x_ptp_io_extts()
function.

Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250312-jk-net-fixes-supported-extts-flags-v2-3-ea930ba82459@intel.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/microchip/lan743x_ptp.c

index 4a777b449ecd03ac0d7576f8570f1a7794fb3d06..0be44dcb339387e9756f36f909f65c20870bc49b 100644 (file)
@@ -942,6 +942,12 @@ static int lan743x_ptp_io_extts(struct lan743x_adapter *adapter, int on,
 
        extts = &ptp->extts[index];
 
+       if (extts_request->flags & ~(PTP_ENABLE_FEATURE |
+                                    PTP_RISING_EDGE |
+                                    PTP_FALLING_EDGE |
+                                    PTP_STRICT_FLAGS))
+               return -EOPNOTSUPP;
+
        if (on) {
                extts_pin = ptp_find_pin(ptp->ptp_clock, PTP_PF_EXTTS, index);
                if (extts_pin < 0)