]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
x86/microcode/AMD: Use sha256() instead of init/update/final
authorEric Biggers <ebiggers@google.com>
Mon, 28 Apr 2025 18:30:06 +0000 (11:30 -0700)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 28 Apr 2025 19:03:58 +0000 (21:03 +0200)
Just call sha256() instead of doing the init/update/final sequence.

No functional changes.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/20250428183006.782501-1-ebiggers@kernel.org
arch/x86/kernel/cpu/microcode/amd.c

index 57bd61f9c69b89d6bd7eee2deb9a99427981212a..b2bbfc4ef3dcf279fe46281ec554c789ddb646d6 100644 (file)
@@ -211,7 +211,6 @@ static bool verify_sha256_digest(u32 patch_id, u32 cur_rev, const u8 *data, unsi
 {
        struct patch_digest *pd = NULL;
        u8 digest[SHA256_DIGEST_SIZE];
-       struct sha256_state s;
        int i;
 
        if (x86_family(bsp_cpuid_1_eax) < 0x17 ||
@@ -230,9 +229,7 @@ static bool verify_sha256_digest(u32 patch_id, u32 cur_rev, const u8 *data, unsi
                return false;
        }
 
-       sha256_init(&s);
-       sha256_update(&s, data, len);
-       sha256_final(&s, digest);
+       sha256(data, len, digest);
 
        if (memcmp(digest, pd->sha256, sizeof(digest))) {
                pr_err("Patch 0x%x SHA256 digest mismatch!\n", patch_id);