]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
projects / users / griffoul / linux.git / commitdiff
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 4c17782)
iio: accel: bmc150: Drop misleading/duplicate chip identifiers
authorStephan Gerhold <stephan@gerhold.net>
Fri, 11 Jun 2021 08:08:56 +0000 (10:08 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 13 Jun 2021 16:00:17 +0000 (17:00 +0100)
Commit 0ad4bf370176 ("iio:accel:bmc150-accel: Use the chip ID to detect
sensor variant") stopped using the I2C/ACPI match data to look up the
bmc150_accel_chip_info. However, the bmc150_accel_chip_info_tbl remained
as-is, with multiple entries with the same chip_id (e.g. 0xFA for
BMC150/BMI055/BMA255). This is redundant now because actually the driver
will always select the first entry with a matching chip_id.

So even if a device probes e.g. with BMA0255 it will end up using the
chip_info for BMC150. And in general that's fine for now, the entries
for BMC150/BMI055/BMA255 were exactly the same anyway (except for the
name, which is replaced with the more accurate one later).

But in this case it's misleading because it suggests that one should
add even more entries with the same chip_id when adding support for
new variants. Let's make that more clear by removing the enum with
the chip identifiers entirely and instead have only one entry per
chip_id.

Note that we may need to bring back some mechanism to differentiate
between different chips with the same chip_id in the future.
For example, BMA250 (currently supported by the bma180 driver) has the
same chip_id = 0x03 as BMA222 even though they have different channel
sizes (8 bits vs 10 bits). But in any case, that mechanism would
need to look quite different from what we have right now.

Cc: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20210611080903.14384-4-stephan@gerhold.net
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/bmc150-accel-core.c patch | blob | history
drivers/iio/accel/bmc150-accel-i2c.c patch | blob | history
drivers/iio/accel/bmc150-accel-spi.c patch | blob | history
drivers/iio/accel/bmc150-accel.h patch | blob | history

diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index a80ee0fdabc51849499f19e7fbb8318bc11c7c24..9ecbd3769593f2d2cb3774caf22da65bcbc5af7a 100644 (file)
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -1097,28 +1097,8 @@ static const struct iio_chan_spec bma280_accel_channels[] =
        BMC150_ACCEL_CHANNELS(14);
 
 static const struct bmc150_accel_chip_info bmc150_accel_chip_info_tbl[] = {
-       [bmc150] = {
-               .name = "BMC150A",
-               .chip_id = 0xFA,
-               .channels = bmc150_accel_channels,
-               .num_channels = ARRAY_SIZE(bmc150_accel_channels),
-               .scale_table = { {9610, BMC150_ACCEL_DEF_RANGE_2G},
-                                {19122, BMC150_ACCEL_DEF_RANGE_4G},
-                                {38344, BMC150_ACCEL_DEF_RANGE_8G},
-                                {76590, BMC150_ACCEL_DEF_RANGE_16G} },
-       },
-       [bmi055] = {
-               .name = "BMI055A",
-               .chip_id = 0xFA,
-               .channels = bmc150_accel_channels,
-               .num_channels = ARRAY_SIZE(bmc150_accel_channels),
-               .scale_table = { {9610, BMC150_ACCEL_DEF_RANGE_2G},
-                                {19122, BMC150_ACCEL_DEF_RANGE_4G},
-                                {38344, BMC150_ACCEL_DEF_RANGE_8G},
-                                {76590, BMC150_ACCEL_DEF_RANGE_16G} },
-       },
-       [bma255] = {
-               .name = "BMA0255",
+       {
+               .name = "BMA255/BMC150/BMI055",
                .chip_id = 0xFA,
                .channels = bmc150_accel_channels,
                .num_channels = ARRAY_SIZE(bmc150_accel_channels),
@@ -1127,7 +1107,7 @@ static const struct bmc150_accel_chip_info bmc150_accel_chip_info_tbl[] = {
                                 {38344, BMC150_ACCEL_DEF_RANGE_8G},
                                 {76590, BMC150_ACCEL_DEF_RANGE_16G} },
        },
-       [bma250e] = {
+       {
                .name = "BMA250E",
                .chip_id = 0xF9,
                .channels = bma250e_accel_channels,
@@ -1137,7 +1117,7 @@ static const struct bmc150_accel_chip_info bmc150_accel_chip_info_tbl[] = {
                                 {153277, BMC150_ACCEL_DEF_RANGE_8G},
                                 {306457, BMC150_ACCEL_DEF_RANGE_16G} },
        },
-       [bma222] = {
+       {
                .name = "BMA222",
                .chip_id = 0x03,
                .channels = bma222e_accel_channels,
@@ -1152,7 +1132,7 @@ static const struct bmc150_accel_chip_info bmc150_accel_chip_info_tbl[] = {
                                 {612916, BMC150_ACCEL_DEF_RANGE_8G},
                                 {1225831, BMC150_ACCEL_DEF_RANGE_16G} },
        },
-       [bma222e] = {
+       {
                .name = "BMA222E",
                .chip_id = 0xF8,
                .channels = bma222e_accel_channels,
@@ -1162,8 +1142,8 @@ static const struct bmc150_accel_chip_info bmc150_accel_chip_info_tbl[] = {
                                 {612915, BMC150_ACCEL_DEF_RANGE_8G},
                                 {1225831, BMC150_ACCEL_DEF_RANGE_16G} },
        },
-       [bma280] = {
-               .name = "BMA0280",
+       {
+               .name = "BMA280",
                .chip_id = 0xFB,
                .channels = bma280_accel_channels,
                .num_channels = ARRAY_SIZE(bma280_accel_channels),
diff --git a/drivers/iio/accel/bmc150-accel-i2c.c b/drivers/iio/accel/bmc150-accel-i2c.c
index d34dddb850d9b3d5252edb29d66a4c5b3645017f..b8bda0dfb495cd944b20c30cdea4f58a6656aae1 100644 (file)
--- a/drivers/iio/accel/bmc150-accel-i2c.c
+++ b/drivers/iio/accel/bmc150-accel-i2c.c
@@ -221,14 +221,14 @@ static int bmc150_accel_remove(struct i2c_client *client)
 }
 
 static const struct acpi_device_id bmc150_accel_acpi_match[] = {
-       {"BSBA0150",    bmc150},
-       {"BMC150A",     bmc150},
-       {"BMI055A",     bmi055},
-       {"BMA0255",     bma255},
-       {"BMA250E",     bma250e},
-       {"BMA222",      bma222},
-       {"BMA222E",     bma222e},
-       {"BMA0280",     bma280},
+       {"BSBA0150"},
+       {"BMC150A"},
+       {"BMI055A"},
+       {"BMA0255"},
+       {"BMA250E"},
+       {"BMA222"},
+       {"BMA222E"},
+       {"BMA0280"},
        {"BOSC0200"},
        {"DUAL250E"},
        { },
@@ -236,13 +236,13 @@ static const struct acpi_device_id bmc150_accel_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, bmc150_accel_acpi_match);
 
 static const struct i2c_device_id bmc150_accel_id[] = {
-       {"bmc150_accel",        bmc150},
-       {"bmi055_accel",        bmi055},
-       {"bma255",              bma255},
-       {"bma250e",             bma250e},
-       {"bma222",              bma222},
-       {"bma222e",             bma222e},
-       {"bma280",              bma280},
+       {"bmc150_accel"},
+       {"bmi055_accel"},
+       {"bma255"},
+       {"bma250e"},
+       {"bma222"},
+       {"bma222e"},
+       {"bma280"},
        {}
 };
 
diff --git a/drivers/iio/accel/bmc150-accel-spi.c b/drivers/iio/accel/bmc150-accel-spi.c
index 74a8aee4f612803f667ae1c8eb24c84d195c72d2..01b42fa6a0158edcb2ea424297a6de0bd2ea80c6 100644 (file)
--- a/drivers/iio/accel/bmc150-accel-spi.c
+++ b/drivers/iio/accel/bmc150-accel-spi.c
@@ -34,26 +34,26 @@ static int bmc150_accel_remove(struct spi_device *spi)
 }
 
 static const struct acpi_device_id bmc150_accel_acpi_match[] = {
-       {"BSBA0150",    bmc150},
-       {"BMC150A",     bmc150},
-       {"BMI055A",     bmi055},
-       {"BMA0255",     bma255},
-       {"BMA250E",     bma250e},
-       {"BMA222",      bma222},
-       {"BMA222E",     bma222e},
-       {"BMA0280",     bma280},
+       {"BSBA0150"},
+       {"BMC150A"},
+       {"BMI055A"},
+       {"BMA0255"},
+       {"BMA250E"},
+       {"BMA222"},
+       {"BMA222E"},
+       {"BMA0280"},
        { },
 };
 MODULE_DEVICE_TABLE(acpi, bmc150_accel_acpi_match);
 
 static const struct spi_device_id bmc150_accel_id[] = {
-       {"bmc150_accel",        bmc150},
-       {"bmi055_accel",        bmi055},
-       {"bma255",              bma255},
-       {"bma250e",             bma250e},
-       {"bma222",              bma222},
-       {"bma222e",             bma222e},
-       {"bma280",              bma280},
+       {"bmc150_accel"},
+       {"bmi055_accel"},
+       {"bma255"},
+       {"bma250e"},
+       {"bma222"},
+       {"bma222e"},
+       {"bma280"},
        {}
 };
 MODULE_DEVICE_TABLE(spi, bmc150_accel_id);
diff --git a/drivers/iio/accel/bmc150-accel.h b/drivers/iio/accel/bmc150-accel.h
index d67d6ed6ae77ef0ff280e99d923b87770f7e2300..47121f070fe9513b9cbc108bf41a3fa88a37300c 100644 (file)
--- a/drivers/iio/accel/bmc150-accel.h
+++ b/drivers/iio/accel/bmc150-accel.h
@@ -68,16 +68,6 @@ struct bmc150_accel_data {
        struct iio_mount_matrix orientation;
 };
 
-enum {
-       bmc150,
-       bmi055,
-       bma255,
-       bma250e,
-       bma222,
-       bma222e,
-       bma280,
-};
-
 int bmc150_accel_core_probe(struct device *dev, struct regmap *regmap, int irq,
                            const char *name, bool block_supported);
 int bmc150_accel_core_remove(struct device *dev);
Unnamed repository; edit this file 'description' to name the repository.