netdevsim: fix sa_idx out of bounds check

Currently if sa_idx is equal to NSIM_IPSEC_MAX_SA_COUNT then
an out-of-bounds read on ipsec->sa will occur. Fix the
incorrect bounds check by using >= rather than >.

Detected by CoverityScan, CID#1470226 ("Out-of-bounds-read")

Fixes: 7699353da875 ("netdevsim: add ipsec offload testing")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Shannon Nelson <shannon.nelson@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/netdevsim/ipsec.c b/drivers/net/netdevsim/ipsec.c
index ceff544510b9bd3b49a6f2f561681b2752a963b4..2dcf6cc269d0d43f81e433d30b9f16e03a05124a 100644 (file)
--- a/drivers/net/netdevsim/ipsec.c
+++ b/drivers/net/netdevsim/ipsec.c
@@ -249,7 +249,7 @@ bool nsim_ipsec_tx(struct netdevsim *ns, struct sk_buff *skb)
        }
 
        sa_idx = xs->xso.offload_handle & ~NSIM_IPSEC_VALID;
-       if (unlikely(sa_idx > NSIM_IPSEC_MAX_SA_COUNT)) {
+       if (unlikely(sa_idx >= NSIM_IPSEC_MAX_SA_COUNT)) {
                netdev_err(ns->netdev, "bad sa_idx=%d max=%d\n",
                           sa_idx, NSIM_IPSEC_MAX_SA_COUNT);
                return false;