mm/zonelist: enumerate zonelists array index

Hardcoding index to zonelists array in gfp_zonelist() is not a good
idea, let's enumerate it to improve readability.

No functional change.

[akpm@linux-foundation.org: coding-style fixes]
[akpm@linux-foundation.org: fix CONFIG_NUMA=n build]
[n-horiguchi@ah.jp.nec.com: fix warning in comparing enumerator]
Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 1dd59abe541d27a0d92f5fe6e5f492521f52e633..91f74e741aa2d4d8e09566bdf70fe121b0b22f6a 100644 (file)
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -384,10 +384,11 @@ static inline enum zone_type gfp_zone(gfp_t flags)
 
 static inline int gfp_zonelist(gfp_t flags)
 {
-       if (IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE))
-               return 1;
-
-       return 0;
+#ifdef CONFIG_NUMA
+       if (unlikely(flags & __GFP_THISNODE))
+               return ZONELIST_NOFALLBACK;
+#endif
+       return ZONELIST_FALLBACK;
 }
 
 /*

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 996384672c7327ab13da16aa1b2e6e291d32e949..12c98dfc31b14481f3f605834a6d9a138a624ea0 100644 (file)
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -571,19 +571,17 @@ static inline bool zone_is_empty(struct zone *zone)
 /* Maximum number of zones on a zonelist */
 #define MAX_ZONES_PER_ZONELIST (MAX_NUMNODES * MAX_NR_ZONES)
 
+enum {
+       ZONELIST_FALLBACK,      /* zonelist with fallback */
 #ifdef CONFIG_NUMA
-
-/*
- * The NUMA zonelists are doubled because we need zonelists that restrict the
- * allocations to a single node for __GFP_THISNODE.
- *
- * [0] : Zonelist with fallback
- * [1] : No fallback (__GFP_THISNODE)
- */
-#define MAX_ZONELISTS 2
-#else
-#define MAX_ZONELISTS 1
+       /*
+        * The NUMA zonelists are doubled because we need zonelists that
+        * restrict the allocations to a single node for __GFP_THISNODE.
+        */
+       ZONELIST_NOFALLBACK,    /* zonelist without fallback (__GFP_THISNODE) */
 #endif
+       MAX_ZONELISTS
+};
 
 /*
  * This struct contains information about a zone in a zonelist. It is stored

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2f6d30db4c9458ee899adf0051f361d87f53c0ae..e40e702ce919a0d5052affcb1fae4ac963576834 100644 (file)
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4148,8 +4148,7 @@ static void set_zonelist_order(void)
 
 static void build_zonelists(pg_data_t *pgdat)
 {
-       int j, node, load;
-       enum zone_type i;
+       int i, node, load;
        nodemask_t used_mask;
        int local_node, prev_node;
        struct zonelist *zonelist;
@@ -4169,7 +4168,7 @@ static void build_zonelists(pg_data_t *pgdat)
        nodes_clear(used_mask);
 
        memset(node_order, 0, sizeof(node_order));
-       j = 0;
+       i = 0;
 
        while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
                /*
@@ -4186,12 +4185,12 @@ static void build_zonelists(pg_data_t *pgdat)
                if (order == ZONELIST_ORDER_NODE)
                        build_zonelists_in_node_order(pgdat, node);
                else
-                       node_order[j++] = node; /* remember order */
+                       node_order[i++] = node; /* remember order */
        }
 
        if (order == ZONELIST_ORDER_ZONE) {
                /* calculate node order -- i.e., DMA last! */
-               build_zonelists_in_zone_order(pgdat, j);
+               build_zonelists_in_zone_order(pgdat, i);
        }
 
        build_thisnode_zonelists(pgdat);