]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mailbox: qcom-cpucp: Mark the irq with IRQF_NO_SUSPEND flag
authorSibi Sankar <quic_sibis@quicinc.com>
Wed, 30 Oct 2024 12:55:12 +0000 (18:25 +0530)
committerJassi Brar <jassisinghbrar@gmail.com>
Sun, 24 Nov 2024 18:56:31 +0000 (12:56 -0600)
The qcom-cpucp mailbox irq is expected to function during suspend-resume
cycle particularly when the scmi cpufreq driver can query the current
frequency using the get_level message after the cpus are brought up during
resume. Hence mark the irq with IRQF_NO_SUSPEND flag to fix the do_xfer
failures we see during resume.

Err Logs:
arm-scmi firmware:scmi: timed out in resp(caller:do_xfer+0x164/0x568)
cpufreq: cpufreq_online: ->get() failed

Reported-by: Johan Hovold <johan+linaro@kernel.org>
Closes: https://lore.kernel.org/lkml/ZtgFj1y5ggipgEOS@hovoldconsulting.com/
Fixes: 0e2a9a03106c ("mailbox: Add support for QTI CPUCP mailbox controller")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/qcom-cpucp-mbox.c

index e5437c294803c7ea96a6dfa1b3da8ce73d538ae8..44f4ed15f818499a9e4c86a5aa0d004f6d92bc93 100644 (file)
@@ -138,7 +138,7 @@ static int qcom_cpucp_mbox_probe(struct platform_device *pdev)
                return irq;
 
        ret = devm_request_irq(dev, irq, qcom_cpucp_mbox_irq_fn,
-                              IRQF_TRIGGER_HIGH, "apss_cpucp_mbox", cpucp);
+                              IRQF_TRIGGER_HIGH | IRQF_NO_SUSPEND, "apss_cpucp_mbox", cpucp);
        if (ret < 0)
                return dev_err_probe(dev, ret, "Failed to register irq: %d\n", irq);