]> www.infradead.org Git - linux.git/commitdiff
iio: imu: bmi323: Fix trigger notification in case of error
authorVasileios Amoiridis <vassilisamir@gmail.com>
Wed, 8 May 2024 15:54:07 +0000 (17:54 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 27 May 2024 08:49:20 +0000 (09:49 +0100)
In case of error in the bmi323_trigger_handler() function, the
function exits without calling the iio_trigger_notify_done()
which is responsible for informing the attached trigger that
the process is done and in case there is a .reenable(), to
call it.

Fixes: 8a636db3aa57 ("iio: imu: Add driver for BMI323 IMU")
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Link: https://lore.kernel.org/r/20240508155407.139805-1-vassilisamir@gmail.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/bmi323/bmi323_core.c

index 5d42ab9b176a389be85102b6dc94a271ffcf1ec5..67d74a1a1b26df83987cf527fcefc4e95c0c7a1c 100644 (file)
@@ -1391,7 +1391,7 @@ static irqreturn_t bmi323_trigger_handler(int irq, void *p)
                                       &data->buffer.channels,
                                       ARRAY_SIZE(data->buffer.channels));
                if (ret)
-                       return IRQ_NONE;
+                       goto out;
        } else {
                for_each_set_bit(bit, indio_dev->active_scan_mask,
                                 BMI323_CHAN_MAX) {
@@ -1400,13 +1400,14 @@ static irqreturn_t bmi323_trigger_handler(int irq, void *p)
                                              &data->buffer.channels[index++],
                                              BMI323_BYTES_PER_SAMPLE);
                        if (ret)
-                               return IRQ_NONE;
+                               goto out;
                }
        }
 
        iio_push_to_buffers_with_timestamp(indio_dev, &data->buffer,
                                           iio_get_time_ns(indio_dev));
 
+out:
        iio_trigger_notify_done(indio_dev->trig);
 
        return IRQ_HANDLED;