]> www.infradead.org Git - nvme.git/commitdiff
hostfs: Fix the NULL vs IS_ERR() bug for __filemap_get_folio()
authorZhangPeng <zhangpeng362@huawei.com>
Mon, 4 Nov 2024 12:34:40 +0000 (20:34 +0800)
committerRichard Weinberger <richard@nod.at>
Fri, 15 Nov 2024 19:55:32 +0000 (20:55 +0100)
The __filemap_get_folio() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.

Fixes: 1da86618bdce ("fs: Convert aops->write_begin to take a folio")
Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/hostfs/hostfs_kern.c

index 8d47c6b70c9f716e14295185c63106a7974241d3..7e51d2cec64b48aa9e43caf40d6eebdd88eb58c6 100644 (file)
@@ -472,8 +472,8 @@ static int hostfs_write_begin(struct file *file, struct address_space *mapping,
 
        *foliop = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
                        mapping_gfp_mask(mapping));
-       if (!*foliop)
-               return -ENOMEM;
+       if (IS_ERR(*foliop))
+               return PTR_ERR(*foliop);
        return 0;
 }