]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
qca_spi: Make driver probing reliable
authorStefan Wahren <wahrenst@gmx.net>
Fri, 6 Dec 2024 18:46:43 +0000 (19:46 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Dec 2024 02:26:48 +0000 (18:26 -0800)
The module parameter qcaspi_pluggable controls if QCA7000 signature
should be checked at driver probe (current default) or not. Unfortunately
this could fail in case the chip is temporary in reset, which isn't under
total control by the Linux host. So disable this check per default
in order to avoid unexpected probe failures.

Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://patch.msgid.link/20241206184643.123399-3-wahrenst@gmx.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qualcomm/qca_spi.c

index d328e770bcbe34c60ffe58d9e1614a6e814a057c..38a779f4b866ca07e31c204aadc59b8702a8f9e9 100644 (file)
@@ -54,7 +54,7 @@ MODULE_PARM_DESC(qcaspi_burst_len, "Number of data bytes per burst. Use 1-5000."
 
 #define QCASPI_PLUGGABLE_MIN 0
 #define QCASPI_PLUGGABLE_MAX 1
-static int qcaspi_pluggable = QCASPI_PLUGGABLE_MIN;
+static int qcaspi_pluggable = QCASPI_PLUGGABLE_MAX;
 module_param(qcaspi_pluggable, int, 0);
 MODULE_PARM_DESC(qcaspi_pluggable, "Pluggable SPI connection (yes/no).");