Add some missing quotes

We are trying to use quotes every time we expand variables. Let's be consistent
and do this everywhere. This patch adds quotes to several paces where we missed
them.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

diff --git a/aiaiai-test-patchset b/aiaiai-test-patchset
index e936265a8c194d6473be9a482d27082ffd630fe8..577e9873532c066fdbb3cda078a2a7c344369bf9 100755 (executable)
--- a/aiaiai-test-patchset
+++ b/aiaiai-test-patchset
@@ -261,7 +261,7 @@ quiet="-q"
 while true; do
        case "$1" in
        -j|--jobs)
-               jobs=$(opt_check_number "$1" "$2")
+               jobs="$(opt_check_number "$1" "$2")"
                shift
                ;;
        -c|--commit-id)

diff --git a/email/aiaiai-email-dispatcher b/email/aiaiai-email-dispatcher
index 5920968466bf8c3edf068966b1475fdd43bb2bfc..9057fd3a04708ed75e9f88ce8bf848ab7b7edab6 100755 (executable)
--- a/email/aiaiai-email-dispatcher
+++ b/email/aiaiai-email-dispatcher
@@ -104,7 +104,7 @@ bigjobs=1
 while true; do
        case "$1" in
        -J|--bigjobs)
-               bigjobs=$(opt_check_number "$1" "$2")
+               bigjobs="$(opt_check_number "$1" "$2")"
                shift
                ;;
        -v|--verbose) verbose="--verbose"
@@ -128,7 +128,7 @@ program_required "inotifywait" ""
 [ -z "$verbose" ] || quiet=
 
 mkdir $verbose -p -- "$1" 1>&2
-queuedir=$(readlink -fv -- "$1"); shift
+queuedir="$(readlink -fv -- "$1")"; shift
 validator="$1"; shift
 
 in_fifo="$(mktemp -dt "$PROG.in_fifo.XXXX")"

diff --git a/email/aiaiai-email-dispatcher-helper b/email/aiaiai-email-dispatcher-helper
index 9dfe115c0b1ae6835d74fc62474fd05d7c052e5a..63c56e1883511cd2905ac33c89cc21b5971ae1a1 100755 (executable)
--- a/email/aiaiai-email-dispatcher-helper
+++ b/email/aiaiai-email-dispatcher-helper
@@ -85,9 +85,9 @@ done
 
 [ "$#" -eq 4 ] || die "Insufficient or too many arguments"
 
-mbox=$(readlink -fv -- "$1"); shift
+mbox="$(readlink -fv -- "$1")"; shift
 fail_file="$1"; shift
-queuedir=$(readlink -fv -- "$1"); shift
+queuedir="$(readlink -fv -- "$1")"; shift
 validator="$1"; shift
 
 tmpdir="$(mktemp -dt "$PROG.XXXX")"

diff --git a/email/aiaiai-email-lda b/email/aiaiai-email-lda
index 770f96e348f47e088c8b348c1cd088de770deeed..ded1641b2d94d62f01b5a07bfe92525bd26c2b82 100755 (executable)
--- a/email/aiaiai-email-lda
+++ b/email/aiaiai-email-lda
@@ -101,7 +101,7 @@ reject_and_reply()
        if [ -n "$pcfg_name" ] && [ "$pcfg_reply_to_all" = "1" ]; then
                # Strip own address
                reply_cc="$(merge_addresses "$reply_cc" "$pcfg_always_cc")"
-               reply_cc=$(strip_address "$reply_cc" "$cfg_ownmail")
+               reply_cc="$(strip_address "$reply_cc" "$cfg_ownmail")"
        else
                reply_cc=
        fi
@@ -440,8 +440,8 @@ process_all_series()
            while IFS= read -r dir; do
                [ -n "$dir" ] || continue
                # Extract the series number
-               n=${dir%-*}
-               n=${n##*_}
+               n="${dir%-*}"
+               n="${n##*_}"
 
                # Clear everything from the current mbox
                truncate -s0 -- "$mbox"
@@ -485,11 +485,11 @@ while true; do
                test_mode=y
                ;;
        --reap-archive)
-               archive_min=$(opt_check_number "$1" "$2")
+               archive_min="$(opt_check_number "$1" "$2")"
                shift
                ;;
        --reap-incomplete)
-               incomplete_min=$(opt_check_number "$1" "$2")
+               incomplete_min="$(opt_check_number "$1" "$2")"
                shift
                ;;
        -v|--verbose) verbose=-v
@@ -514,8 +514,8 @@ program_required "grep" ""
 program_required "sed" ""
 program_required "formail" ""
 
-workdir=$(readlink -fv -- "$1"); shift
-cfgfile=$(readlink -fv -- "$1"); shift
+workdir="$(readlink -fv -- "$1")"; shift
+cfgfile="$(readlink -fv -- "$1")"; shift
 
 parse_config "$cfgfile"
 

diff --git a/gerrit/aiaiai-jenkins-test-patchset b/gerrit/aiaiai-jenkins-test-patchset
index 86294fcb14b22cfaac65c4cc0dcfefc6b84afad9..53da26e22e5b676aad2e693d6ff5bc626b82ceb7 100755 (executable)
--- a/gerrit/aiaiai-jenkins-test-patchset
+++ b/gerrit/aiaiai-jenkins-test-patchset
@@ -115,7 +115,7 @@ quiet="-q"
 while true; do
        case "$1" in
        -j|--jobs)
-               jobs=$(opt_check_number "$1" "$2")
+               jobs="$(opt_check_number "$1" "$2")"
                shift
                ;;
        -w|--workdir)
@@ -191,11 +191,11 @@ gerrit_url="$1"; shift
 defconfigs="$@"
 
 # Extract the port number to a separate variable
-gerrit_port=$(printf "%s" "$gerrit_url" | sed -n -e 's/\([^:]*\):\{0,1\}\([0-9]*\)$/\2/p')
+gerrit_port="$(printf "%s" "$gerrit_url" | sed -n -e 's/\([^:]*\):\{0,1\}\([0-9]*\)$/\2/p')"
 if [ -z "$gerrit_port" ]; then
        gerrit_port=29418
 else
-       gerrit_url=$(printf "%s" "$gerrit_url"  | sed -n -e 's/\([^:]*\):\{0,1\}\([0-9]*\)$/\1/p')
+       gerrit_url="$(printf "%s" "$gerrit_url"  | sed -n -e 's/\([^:]*\):\{0,1\}\([0-9]*\)$/\1/p')"
 fi
 
 verbose "Gerrit URL: $gerrit_url, port $gerrit_port"

diff --git a/helpers/aiaiai-make-kernel b/helpers/aiaiai-make-kernel
index 5604f6c9a2e768c699033f8384eea191bdbb1d6c..4f438900e0b4e23a918c18de8d986639d81c3ab4 100755 (executable)
--- a/helpers/aiaiai-make-kernel
+++ b/helpers/aiaiai-make-kernel
@@ -170,7 +170,7 @@ while true; do
                shift
                ;;
        -j|--jobs)
-               jobs=$(opt_check_number "$1" "$2")
+               jobs="$(opt_check_number "$1" "$2")"
                shift
                ;;
        -O|--stdout)

diff --git a/helpers/aiaiai-sh-functions b/helpers/aiaiai-sh-functions
index b32e4571e6b8aefc197f632b87919af109ad5c47..15fb5db2ace848b5c3f4ec9033642179cc7f1594 100644 (file)
--- a/helpers/aiaiai-sh-functions
+++ b/helpers/aiaiai-sh-functions
@@ -22,7 +22,7 @@ print_separator()
        local i=0
 
        while [ $i -lt 80 ]; do
-               i=$(($i+1));
+               i="$(($i+1))";
                printf "-";
        done
        echo

diff --git a/helpers/aiaiai-test-bisectability b/helpers/aiaiai-test-bisectability
index 913c0a6cbc251a4ea1bdb7aee9bdd2778a1cc6d4..948a8074f8d3f680c6d027ba67cef2c65370aea4 100755 (executable)
--- a/helpers/aiaiai-test-bisectability
+++ b/helpers/aiaiai-test-bisectability
@@ -140,7 +140,7 @@ quiet="-q"
 while true; do
        case "$1" in
        -j|--jobs)
-               jobs=$(opt_check_number "$1" "$2")
+               jobs="$(opt_check_number "$1" "$2")"
                shift
                ;;
        -c|--commit-id)