]> www.infradead.org Git - users/hch/configfs.git/commitdiff
drm/xe/oa: Don't use hardcoded values
authorOhad Sharabi <osharabi@habana.ai>
Sun, 21 Jul 2024 07:13:35 +0000 (10:13 +0300)
committerAshutosh Dixit <ashutosh.dixit@intel.com>
Mon, 22 Jul 2024 05:38:25 +0000 (22:38 -0700)
The current implementation uses hardcoded values instead of common defines.

v2:
 - Make the commit a regular commit instead of a fixup commit
 - slightly modify commit message

Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240721071335.101234-1-osharabi@habana.ai
drivers/gpu/drm/xe/xe_oa.c

index 6d69f751bf78d28907be5b3a0b812f4e44e8e3c9..3ef92eb8fbb1ed670c15ca98797dd416c1a1df43 100644 (file)
@@ -641,7 +641,7 @@ static void xe_oa_store_flex(struct xe_oa_stream *stream, struct xe_lrc *lrc,
        u32 offset = xe_bo_ggtt_addr(lrc->bo);
 
        do {
-               bb->cs[bb->len++] = MI_STORE_DATA_IMM | BIT(22) /* GGTT */ | 2;
+               bb->cs[bb->len++] = MI_STORE_DATA_IMM | MI_SDI_GGTT | MI_SDI_NUM_DW(1);
                bb->cs[bb->len++] = offset + flex->offset * sizeof(u32);
                bb->cs[bb->len++] = 0;
                bb->cs[bb->len++] = flex->value;