]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: am437x: don't fill in bus_info
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 23 Sep 2023 15:21:02 +0000 (17:21 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 27 Sep 2023 08:47:23 +0000 (10:47 +0200)
Let the V4L2 core fill this in.

This fixes this warning:

drivers/media/platform/ti/am437x/am437x-vpfe.c: In function 'vpfe_querycap':
drivers/media/platform/ti/am437x/am437x-vpfe.c:1279:35: warning: '%s' directive output may be truncated writing up to 35 bytes into a region of size 23 [-Wformat-truncation=]
 1279 |                         "platform:%s", vpfe->v4l2_dev.name);
      |                                   ^~
drivers/media/platform/ti/am437x/am437x-vpfe.c:1278:9: note: 'snprintf' output between 10 and 45 bytes into a destination of size 32
 1278 |         snprintf(cap->bus_info, sizeof(cap->bus_info),
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1279 |                         "platform:%s", vpfe->v4l2_dev.name);
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
drivers/media/platform/ti/am437x/am437x-vpfe.c

index 63092013d476ef32e11cce1085eca04fafde9058..5fa2ea9025d96b919fd456cd6b1943dfaff2239a 100644 (file)
@@ -1271,12 +1271,8 @@ static inline void vpfe_attach_irq(struct vpfe_device *vpfe)
 static int vpfe_querycap(struct file *file, void  *priv,
                         struct v4l2_capability *cap)
 {
-       struct vpfe_device *vpfe = video_drvdata(file);
-
        strscpy(cap->driver, VPFE_MODULE_NAME, sizeof(cap->driver));
        strscpy(cap->card, "TI AM437x VPFE", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info),
-                       "platform:%s", vpfe->v4l2_dev.name);
        return 0;
 }