]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
perf bpf-filter: Return -ENOMEM directly when pfi allocation fails
authorHao Ge <gehao@kylinos.cn>
Wed, 13 Nov 2024 03:05:37 +0000 (11:05 +0800)
committerNamhyung Kim <namhyung@kernel.org>
Fri, 22 Nov 2024 21:36:00 +0000 (13:36 -0800)
Directly return -ENOMEM when pfi allocation fails,
instead of performing other operations on pfi.

Fixes: 0fe2b18ddc40 ("perf bpf-filter: Support multiple events properly")
Signed-off-by: Hao Ge <gehao@kylinos.cn>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: hao.ge@linux.dev
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20241113030537.26732-1-hao.ge@linux.dev
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/bpf-filter.c

index e87b6789eb9ef3b9ce174da383e43d465a07278e..a4fdf6911ec1c32e799983c0951f39b16f77b7b7 100644 (file)
@@ -375,7 +375,7 @@ static int create_idx_hash(struct evsel *evsel, struct perf_bpf_filter_entry *en
        pfi = zalloc(sizeof(*pfi));
        if (pfi == NULL) {
                pr_err("Cannot save pinned filter index\n");
-               goto err;
+               return -ENOMEM;
        }
 
        pfi->evsel = evsel;