]> www.infradead.org Git - users/hch/misc.git/commitdiff
blk-wbt: Eliminate ambiguity in the comments of struct rq_wb
authorTang Yizhou <yizhou.tang@shopee.com>
Sun, 27 Jul 2025 17:39:58 +0000 (01:39 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 11 Aug 2025 16:21:38 +0000 (10:21 -0600)
In the current implementation, the last_issue and last_comp members of
struct rq_wb are used only by read requests and not by non-throttled write
requests. Therefore, eliminate the ambiguity here.

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20250727173959.160835-3-yizhou.tang@shopee.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-wbt.c

index 30886d44f6cd253157cb0fa850d1d94fb0322f94..eb8037bae0bda662e683a5e5427a653a8c66fcb9 100644 (file)
@@ -85,8 +85,8 @@ struct rq_wb {
        u64 sync_issue;
        void *sync_cookie;
 
-       unsigned long last_issue;               /* last non-throttled issue */
-       unsigned long last_comp;                /* last non-throttled comp */
+       unsigned long last_issue;       /* issue time of last read rq */
+       unsigned long last_comp;        /* completion time of last read rq */
        unsigned long min_lat_nsec;
        struct rq_qos rqos;
        struct rq_wait rq_wait[WBT_NUM_RWQ];