net: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230310144716.1544083-1-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index 510822d6d0d90ce4fe012388e71733846c57c115..bf10d0688eea23fa1c42b5d7740cd864ca61b131 100644 (file)
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -131,7 +131,7 @@ bool of_mdiobus_child_is_phy(struct device_node *child)
                return true;
        }
 
-       if (!of_find_property(child, "compatible", NULL))
+       if (!of_property_present(child, "compatible"))
                return true;
 
        return false;
@@ -203,7 +203,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
        /* auto scan for PHYs with empty reg property */
        for_each_available_child_of_node(np, child) {
                /* Skip PHYs with reg property set */
-               if (of_find_property(child, "reg", NULL))
+               if (of_property_present(child, "reg"))
                        continue;
 
                for (addr = 0; addr < PHY_MAX_ADDR; addr++) {

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 52527b61341edd1dffddb4029d4944f048e3955b..e406e11481a6212dc358167265980ba2b4eb4272 100644 (file)
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -129,7 +129,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
                sdio->drive_strength = val;
 
        /* make sure there are interrupts defined in the node */
-       if (!of_find_property(np, "interrupts", NULL))
+       if (!of_property_present(np, "interrupts"))
                return;
 
        irq = irq_of_parse_and_map(np, 0);