drm/amd/display: Remove redundant assignments

[WHAT & HOW]
log2_blk_height and log2_blk_width are assigned to 0 and then
immediately are updated to other values. The assignments to zero are
redudant and removed.

This fixes 18 UNUSED_VALUE issues reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c
index 4fce64a030b60ac09f82b18c118608e1b1fabd3a..390c1a77fda6a421053fafe0b36fefebb01f67a7 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c
@@ -443,8 +443,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib,
        blk_bytes = surf_linear ?
                        256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);
        log2_blk_bytes = dml_log2((double) blk_bytes);
-       log2_blk_height = 0;
-       log2_blk_width = 0;
 
        // remember log rule
        // "+" in log is multiply
@@ -491,8 +489,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib,
                        - log2_meta_req_height;
        meta_req_width = 1 << log2_meta_req_width;
        meta_req_height = 1 << log2_meta_req_height;
-       log2_meta_row_height = 0;
-       meta_row_width_ub = 0;
 
        // the dimensions of a meta row are meta_row_width x meta_row_height in elements.
        // calculate upper bound of the meta_row_width

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c
index 3fa9a5da02f6a43eab859b675290b5791f4ed154..843d6004258ce9c835dfbd281703675191796442 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c
@@ -443,8 +443,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib,
        blk_bytes = surf_linear ?
                        256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);
        log2_blk_bytes = dml_log2((double) blk_bytes);
-       log2_blk_height = 0;
-       log2_blk_width = 0;
 
        // remember log rule
        // "+" in log is multiply
@@ -491,8 +489,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib,
                        - log2_meta_req_height;
        meta_req_width = 1 << log2_meta_req_width;
        meta_req_height = 1 << log2_meta_req_height;
-       log2_meta_row_height = 0;
-       meta_row_width_ub = 0;
 
        // the dimensions of a meta row are meta_row_width x meta_row_height in elements.
        // calculate upper bound of the meta_row_width

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c
index 9e1c18b90805d26003277b6f5c1d842f7ac0d75b..5718000627b08b955a58f5df80e5e2e4ad5458ae 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c
@@ -435,8 +435,6 @@ static void get_meta_and_pte_attr(
        blk_bytes = surf_linear ?
                        256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);
        log2_blk_bytes = dml_log2((double) blk_bytes);
-       log2_blk_height = 0;
-       log2_blk_width = 0;
 
        // remember log rule
        // "+" in log is multiply
@@ -485,8 +483,6 @@ static void get_meta_and_pte_attr(
                        - log2_meta_req_height;
        meta_req_width = 1 << log2_meta_req_width;
        meta_req_height = 1 << log2_meta_req_height;
-       log2_meta_row_height = 0;
-       meta_row_width_ub = 0;
 
        // the dimensions of a meta row are meta_row_width x meta_row_height in elements.
        // calculate upper bound of the meta_row_width

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c
index b28fcc8608ff869a0ad2e7e7abb143bf8052beff..76d3bb3c91550c47913f087cb39d7a3b6d3c705c 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c
@@ -392,8 +392,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib,
        blk_bytes = surf_linear ?
                256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);
        log2_blk_bytes = dml_log2((double)blk_bytes);
-       log2_blk_height = 0;
-       log2_blk_width = 0;
 
        // remember log rule
        // "+" in log is multiply
@@ -464,8 +462,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib,
                - log2_meta_req_height;
        meta_req_width = 1 << log2_meta_req_width;
        meta_req_height = 1 << log2_meta_req_height;
-       log2_meta_row_height = 0;
-       meta_row_width_ub = 0;
 
        // the dimensions of a meta row are meta_row_width x meta_row_height in elements.
        // calculate upper bound of the meta_row_width

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
index b57b095cd4a81485785c826b0db7773fc36bfe6a..c46bda2141acd5ee9fa41d3ab95dff47cb5450c8 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
@@ -413,8 +413,6 @@ static void get_meta_and_pte_attr(
        log2_blk256_height = dml_log2((double) blk256_height);
        blk_bytes = surf_linear ? 256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);
        log2_blk_bytes = dml_log2((double) blk_bytes);
-       log2_blk_height = 0;
-       log2_blk_width = 0;
 
        // remember log rule
        // "+" in log is multiply
@@ -481,8 +479,6 @@ static void get_meta_and_pte_attr(
        log2_meta_req_width = log2_meta_req_bytes + 8 - log2_bytes_per_element - log2_meta_req_height;
        meta_req_width = 1 << log2_meta_req_width;
        meta_req_height = 1 << log2_meta_req_height;
-       log2_meta_row_height = 0;
-       meta_row_width_ub = 0;
 
        // the dimensions of a meta row are meta_row_width x meta_row_height in elements.
        // calculate upper bound of the meta_row_width

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
index 61b3bebf24c96c808d52572edefc7e8fa396c301..b7d2a0caec11b0bb0d8953d71987306dda6c1be7 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
@@ -501,8 +501,6 @@ static void get_meta_and_pte_attr(
        log2_blk256_height = dml_log2((double) blk256_height);
        blk_bytes = surf_linear ? 256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);
        log2_blk_bytes = dml_log2((double) blk_bytes);
-       log2_blk_height = 0;
-       log2_blk_width = 0;
 
        // remember log rule
        // "+" in log is multiply
@@ -569,8 +567,6 @@ static void get_meta_and_pte_attr(
        log2_meta_req_width = log2_meta_req_bytes + 8 - log2_bytes_per_element - log2_meta_req_height;
        meta_req_width = 1 << log2_meta_req_width;
        meta_req_height = 1 << log2_meta_req_height;
-       log2_meta_row_height = 0;
-       meta_row_width_ub = 0;
 
        // the dimensions of a meta row are meta_row_width x meta_row_height in elements.
        // calculate upper bound of the meta_row_width