]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: platform: ti: Add missing check for devm_regulator_get
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Wed, 4 Jan 2023 08:55:37 +0000 (09:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:41 +0000 (09:33 +0100)
[ Upstream commit da8e05f84a11c3cc3b0ba0a3c62d20e358002d99 ]

Add check for the return value of devm_regulator_get since it may return
error pointer.

Fixes: 448de7e7850b ("[media] omap3isp: OMAP3 ISP core")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/ti/omap3isp/isp.c

index 24d2383400b0a0a86827c3bd553c77fd33be20cb..11ae479ee89c8c809c8f8d777777a6b345b7b557 100644 (file)
@@ -2308,7 +2308,16 @@ static int isp_probe(struct platform_device *pdev)
 
        /* Regulators */
        isp->isp_csiphy1.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy1");
+       if (IS_ERR(isp->isp_csiphy1.vdd)) {
+               ret = PTR_ERR(isp->isp_csiphy1.vdd);
+               goto error;
+       }
+
        isp->isp_csiphy2.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy2");
+       if (IS_ERR(isp->isp_csiphy2.vdd)) {
+               ret = PTR_ERR(isp->isp_csiphy2.vdd);
+               goto error;
+       }
 
        /* Clocks
         *