]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
qla2xxx: Retry switch command on time out
authorQuinn Tran <quinn.tran@cavium.com>
Wed, 6 Dec 2017 09:07:37 +0000 (14:37 +0530)
committerSomasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Fri, 5 Jan 2018 21:05:16 +0000 (13:05 -0800)
Orabug: 27235104

Retry GID_PN & GPN_ID switch commands for time out case.

Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
Cc: <stable@vger.kernel.org> # 4.10+
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
[ Upstream commit 25ad76b703d9ad536f3411b15b1070aeb059ab55 ]
Signed-off-by: Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
drivers/scsi/qla2xxx/qla_gs.c

index 39019d8693d0c3b3605edcc23f1c3f659ba92892..2d139447feb38b09d3410e37e6b14eb4a86022f0 100644 (file)
@@ -175,6 +175,9 @@ qla2x00_chk_ms_status(scsi_qla_host_t *vha, ms_iocb_entry_t *ms_pkt,
                                set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags);
                        }
                        break;
+               case CS_TIMEOUT:
+                       rval = QLA_FUNCTION_TIMEOUT;
+                       /* drop through */
                default:
                        ql_dbg(ql_dbg_disc, vha, 0x2033,
                            "%s failed, completion status (%x) on port_id: "
@@ -2861,9 +2864,21 @@ static void qla2x00_async_gidpn_sp_done(void *s, int res)
        ea.rc = res;
        ea.event = FCME_GIDPN_DONE;
 
-       ql_dbg(ql_dbg_disc, vha, 0x204f,
-           "Async done-%s res %x, WWPN %8phC ID %3phC \n",
-           sp->name, res, fcport->port_name, id);
+       if (res == QLA_FUNCTION_TIMEOUT) {
+               ql_dbg(ql_dbg_disc, sp->vha, 0xffff,
+                   "Async done-%s WWPN %8phC timed out.\n",
+                   sp->name, fcport->port_name);
+               qla24xx_post_gidpn_work(sp->vha, fcport);
+               sp->free(sp);
+               return;
+       } else if (res)
+               ql_dbg(ql_dbg_disc, sp->vha, 0xffff,
+                   "Async done-%s fail res %x, WWPN %8phC \n",
+                   sp->name, res, fcport->port_name);
+       else
+               ql_dbg(ql_dbg_disc, vha, 0x204f,
+                   "Async done-%s good WWPN %8phC ID %3phC\n",
+                   sp->name, fcport->port_name, id);
 
        qla2x00_fcport_event_handler(vha, &ea);
 
@@ -3198,6 +3213,14 @@ static void qla2x00_async_gpnid_sp_done(void *s, int res)
        ea.rc = res;
        ea.event = FCME_GPNID_DONE;
 
+       if (res) {
+               if (res == QLA_FUNCTION_TIMEOUT) {
+                       qla24xx_post_gpnid_work(sp->vha, &ea.id);
+               }
+               sp->free(sp);
+               return;
+       }
+
        qla2x00_fcport_event_handler(vha, &ea);
 
        e = qla2x00_alloc_work(vha, QLA_EVT_GPNID_DONE);