]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/pci-bridge/cxl_upstream: Fix bandwidth entry base unit for SSLBIS
authorDave Jiang <dave.jiang@intel.com>
Mon, 4 Sep 2023 13:28:04 +0000 (14:28 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 21 Sep 2023 08:31:18 +0000 (11:31 +0300)
According to ACPI spec 6.5 5.2.28.4 System Locality Latency and Bandwidth
Information Structure, if the "Entry Base Unit" is 1024 for BW and the
matrix entry has the value of 100, the BW is 100 GB/s. So the
entry_base_unit should be changed from 1000 to 1024 given the comment notes
it's 16GB/s for .latency_bandwidth.

Fixes: 882877fc359d ("hw/pci-bridge/cxl-upstream: Add a CDAT table access DOE")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/pci-bridge/cxl_upstream.c

index 9159f48a8cb7c514169d1ddc671b4828a4c6b587..2b9cf0cc97949329ad800251b13ebb914da31ed9 100644 (file)
@@ -262,7 +262,7 @@ static int build_cdat_table(CDATSubHeader ***cdat_table, void *priv)
                 .length = sslbis_size,
             },
             .data_type = HMATLB_DATA_TYPE_ACCESS_BANDWIDTH,
-            .entry_base_unit = 1000,
+            .entry_base_unit = 1024,
         },
     };