net/mlx5e: Fix a couple error codes

If kvzalloc() fails then return -ENOMEM.  Don't return success.

Fixes: 3b20949cb21b ("net/mlx5e: Add MACsec RX steering rules")
Fixes: e467b283ffd5 ("net/mlx5e: Add MACsec TX steering rules")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c
index 1ac0cf04e8113bcf9726230dead891248c54f402..96cec6d826c2da4d4e08cc9375498a357b2ad86e 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c
@@ -250,7 +250,7 @@ static int macsec_fs_tx_create(struct mlx5e_macsec_fs *macsec_fs)
        struct mlx5_flow_handle *rule;
        struct mlx5_flow_spec *spec;
        u32 *flow_group_in;
-       int err = 0;
+       int err;
 
        ns = mlx5_get_flow_namespace(macsec_fs->mdev, MLX5_FLOW_NAMESPACE_EGRESS_MACSEC);
        if (!ns)
@@ -261,8 +261,10 @@ static int macsec_fs_tx_create(struct mlx5e_macsec_fs *macsec_fs)
                return -ENOMEM;
 
        flow_group_in = kvzalloc(inlen, GFP_KERNEL);
-       if (!flow_group_in)
+       if (!flow_group_in) {
+               err = -ENOMEM;
                goto out_spec;
+       }
 
        tx_tables = &tx_fs->tables;
        ft_crypto = &tx_tables->ft_crypto;
@@ -898,7 +900,7 @@ static int macsec_fs_rx_create(struct mlx5e_macsec_fs *macsec_fs)
        struct mlx5_flow_handle *rule;
        struct mlx5_flow_spec *spec;
        u32 *flow_group_in;
-       int err = 0;
+       int err;
 
        ns = mlx5_get_flow_namespace(macsec_fs->mdev, MLX5_FLOW_NAMESPACE_KERNEL_RX_MACSEC);
        if (!ns)
@@ -909,8 +911,10 @@ static int macsec_fs_rx_create(struct mlx5e_macsec_fs *macsec_fs)
                return -ENOMEM;
 
        flow_group_in = kvzalloc(inlen, GFP_KERNEL);
-       if (!flow_group_in)
+       if (!flow_group_in) {
+               err = -ENOMEM;
                goto free_spec;
+       }
 
        rx_tables = &rx_fs->tables;
        ft_crypto = &rx_tables->ft_crypto;