]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/xe/device: move flr to devm
authorMatthew Auld <matthew.auld@intel.com>
Wed, 22 May 2024 10:21:52 +0000 (11:21 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Wed, 22 May 2024 12:22:39 +0000 (13:22 +0100)
Should be called when driver is removed, not when this particular driver
instance is destroyed.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240522102143.128069-27-matthew.auld@intel.com
drivers/gpu/drm/xe/xe_device.c

index 043697e9e1b69569f7cc4c48320a9d2a40cc38c0..866c996df27a8d02c53e870eec4e2b8b39976b94 100644 (file)
@@ -381,7 +381,7 @@ static void xe_driver_flr(struct xe_device *xe)
        xe_mmio_write32(gt, GU_DEBUG, DRIVERFLR_STATUS);
 }
 
-static void xe_driver_flr_fini(struct drm_device *drm, void *arg)
+static void xe_driver_flr_fini(void *arg)
 {
        struct xe_device *xe = arg;
 
@@ -586,7 +586,7 @@ int xe_device_probe(struct xe_device *xe)
        err = xe_devcoredump_init(xe);
        if (err)
                return err;
-       err = drmm_add_action_or_reset(&xe->drm, xe_driver_flr_fini, xe);
+       err = devm_add_action_or_reset(xe->drm.dev, xe_driver_flr_fini, xe);
        if (err)
                return err;