vdpa_sim: cleanup kiovs in vdpasim_free()

vringh_getdesc_iotlb() allocates memory to store the kvec, that
is freed with vringh_kiov_cleanup().

vringh_getdesc_iotlb() is able to reuse a kvec previously allocated,
so in order to avoid to allocate the kvec for each request, we are
not calling vringh_kiov_cleanup() when we finished to handle a
request, but we should call it when we free the entire device.

Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20210315163450.254396-8-sgarzare@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index a92c0888009854629ce723a9d2315c853b6578fa..14dc2d3d983e4c11a3f269d73b1de9c201c5bfa0 100644 (file)
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -562,8 +562,15 @@ static int vdpasim_dma_unmap(struct vdpa_device *vdpa, u64 iova, u64 size)
 static void vdpasim_free(struct vdpa_device *vdpa)
 {
        struct vdpasim *vdpasim = vdpa_to_sim(vdpa);
+       int i;
 
        cancel_work_sync(&vdpasim->work);
+
+       for (i = 0; i < vdpasim->dev_attr.nvqs; i++) {
+               vringh_kiov_cleanup(&vdpasim->vqs[i].out_iov);
+               vringh_kiov_cleanup(&vdpasim->vqs[i].in_iov);
+       }
+
        put_iova_domain(&vdpasim->iova);
        iova_cache_put();
        kvfree(vdpasim->buffer);