PCI/AER: Configure ECRC only if AER is native

As the ECRC configuration bits are part of AER registers, configure ECRC
only if AER is natively owned by the kernel.

Link: https://lore.kernel.org/r/20230112072111.20063-1-vidyas@nvidia.com
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 6cfa6e3996cf75ee6bb1e8b399daa4d5701ab92b..ecdb9530af8a90b0ccafa8a4ad298d63db74bb07 100644 (file)
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -4296,7 +4296,9 @@
                                specified, e.g., 12@pci:8086:9c22:103c:198f
                                for 4096-byte alignment.
                ecrc=           Enable/disable PCIe ECRC (transaction layer
-                               end-to-end CRC checking).
+                               end-to-end CRC checking). Only effective if
+                               OS has native AER control (either granted by
+                               ACPI _OSC or forced via "pcie_ports=native")
                                bios: Use BIOS/firmware settings. This is the
                                the default.
                                off: Turn ECRC off

diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 625f7b2cafe42000f60ff0f9c505aee206e4b65d..d7ee79d7b192815a1032c4dec2b2d675025aed9f 100644 (file)
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -184,6 +184,9 @@ static int disable_ecrc_checking(struct pci_dev *dev)
  */
 void pcie_set_ecrc_checking(struct pci_dev *dev)
 {
+       if (!pcie_aer_is_native(dev))
+               return;
+
        switch (ecrc_policy) {
        case ECRC_POLICY_DEFAULT:
                return;