]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: mana: Fix memory leak in mana_gd_setup_irqs
authorMaxim Levitsky <mlevitsk@redhat.com>
Mon, 9 Dec 2024 17:57:50 +0000 (12:57 -0500)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Dec 2024 04:21:04 +0000 (20:21 -0800)
Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
doesn't free this temporary array in the success path.

This was caught by kmemleak.

Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: Yury Norov <yury.norov@gmail.com>
Link: https://patch.msgid.link/20241209175751.287738-2-mlevitsk@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microsoft/mana/gdma_main.c

index 550be6dc305db3d943432f7d4a5dc8adfb9455a8..5babd217c7eda8be3c5cb3ca130e5e7aaa8fa800 100644 (file)
@@ -1375,6 +1375,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
        gc->max_num_msix = nvec;
        gc->num_msix_usable = nvec;
        cpus_read_unlock();
+       kfree(irqs);
        return 0;
 
 free_irq: