USB: legousbtower: stop interrupt-out URB unconditionally

Stop also the interrupt-out URB unconditionally in
tower_abort_transfers() which is called from release() (for connected
devices). Calling usb_kill_urb() for an idle URB is perfectly fine.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191105084152.16322-8-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
index 33533faa019eeda8c8531f53c0d56ae34c7bfb80..3e409dfe172c09ce3a43602bb86e52f77b26d443 100644 (file)
--- a/drivers/usb/misc/legousbtower.c
+++ b/drivers/usb/misc/legousbtower.c
@@ -448,8 +448,7 @@ static void tower_abort_transfers (struct lego_usb_tower *dev)
 {
        /* shutdown transfer */
        usb_kill_urb(dev->interrupt_in_urb);
-       if (dev->interrupt_out_busy)
-               usb_kill_urb(dev->interrupt_out_urb);
+       usb_kill_urb(dev->interrupt_out_urb);
 }