scsi: fnic: Remove unnecessary else to fix warning in FDLS FIP

Implement review comments from Martin:
    Remove unnecessary else from fip.c to fix a warning.

Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250106224451.3597-3-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c
index aaf5f768a9bde6be61e0b56d50155ae62bb71d25..7bb85949033fee30952353e389f9dcac8201c895 100644 (file)
--- a/drivers/scsi/fnic/fip.c
+++ b/drivers/scsi/fnic/fip.c
@@ -154,16 +154,15 @@ void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct fip_header *fiph)
                        vlan->state = FIP_VLAN_AVAIL;
                        list_add_tail(&vlan->list, &fnic->vlan_list);
                        break;
-               } else {
-                       FNIC_FIP_DBG(KERN_INFO, fnic->host,
-                                    fnic->fnic_num,
-                                    "Invalid descriptor type(%x) in VLan response\n",
-                                    vlan_desc->fd_desc.fip_dtype);
-                       /*
-                        * Note : received a type=2 descriptor here i.e. FIP
-                        * MAC Address Descriptor
-                        */
                }
+               FNIC_FIP_DBG(KERN_INFO, fnic->host,
+                            fnic->fnic_num,
+                            "Invalid descriptor type(%x) in VLan response\n",
+                            vlan_desc->fd_desc.fip_dtype);
+               /*
+                * Note : received a type=2 descriptor here i.e. FIP
+                * MAC Address Descriptor
+                */
                cur_desc += vlan_desc->fd_desc.fip_dlen;
                desc_len -= vlan_desc->fd_desc.fip_dlen;
        }