scsi: target: Shorten ALUA error messages

Do not print tg_pt_gp->tg_pt_gp_valid_id if we already know that it is zero.

Link: https://lore.kernel.org/r/20210415220826.29438-20-bvanassche@acm.org
Cc: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 9cb1ca8421c8d802908628d4dede9baa08377afe..4b2e49341ad6f997580e91b33ebdc24192272419 100644 (file)
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2745,8 +2745,7 @@ static ssize_t target_tg_pt_gp_alua_access_state_store(struct config_item *item,
        int new_state, ret;
 
        if (!tg_pt_gp->tg_pt_gp_valid_id) {
-               pr_err("Unable to do implicit ALUA on non valid"
-                       " tg_pt_gp ID: %hu\n", tg_pt_gp->tg_pt_gp_valid_id);
+               pr_err("Unable to do implicit ALUA on invalid tg_pt_gp ID\n");
                return -EINVAL;
        }
        if (!target_dev_configured(dev)) {
@@ -2797,9 +2796,7 @@ static ssize_t target_tg_pt_gp_alua_access_status_store(
        int new_status, ret;
 
        if (!tg_pt_gp->tg_pt_gp_valid_id) {
-               pr_err("Unable to do set ALUA access status on non"
-                       " valid tg_pt_gp ID: %hu\n",
-                       tg_pt_gp->tg_pt_gp_valid_id);
+               pr_err("Unable to set ALUA access status on invalid tg_pt_gp ID\n");
                return -EINVAL;
        }
 
@@ -2852,9 +2849,7 @@ static ssize_t target_tg_pt_gp_alua_support_##_name##_store(              \
        int ret;                                                        \
                                                                        \
        if (!t->tg_pt_gp_valid_id) {                                    \
-               pr_err("Unable to do set " #_name " ALUA state on non"  \
-                      " valid tg_pt_gp ID: %hu\n",                     \
-                      t->tg_pt_gp_valid_id);                           \
+               pr_err("Unable to set " #_name " ALUA state on invalid tg_pt_gp ID\n"); \
                return -EINVAL;                                         \
        }                                                               \
                                                                        \