]> www.infradead.org Git - users/hch/block.git/commitdiff
can: m_can: Move hrtimer init to m_can_class_register
authorMarkus Schneider-Pargmann <msp@baylibre.com>
Wed, 7 Feb 2024 09:32:08 +0000 (10:32 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 12 Feb 2024 16:02:42 +0000 (17:02 +0100)
The hrtimer_init() is called in m_can_plat_probe() and the hrtimer
function is set in m_can_class_register(). For readability it is better
to keep these two together in m_can_class_register().

Cc: Judith Mendez <jm@ti.com>
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/all/20240207093220.2681425-3-msp@baylibre.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c
drivers/net/can/m_can/m_can_platform.c

index 2395b1225cc8a72aae923b1e2c6ec98046d6a7f5..45391492339e6e05f38749c3ef002b70ea2295a8 100644 (file)
@@ -2070,8 +2070,12 @@ int m_can_class_register(struct m_can_classdev *cdev)
                        goto clk_disable;
        }
 
-       if (!cdev->net->irq)
+       if (!cdev->net->irq) {
+               dev_dbg(cdev->dev, "Polling enabled, initialize hrtimer");
+               hrtimer_init(&cdev->hrtimer, CLOCK_MONOTONIC,
+                            HRTIMER_MODE_REL_PINNED);
                cdev->hrtimer.function = &hrtimer_callback;
+       }
 
        ret = m_can_dev_setup(cdev);
        if (ret)
index cdb28d6a092c6d043dd4af65459943abc6bc473c..ab1b8211a61cf544c3060479dbc4df5a2ac550e8 100644 (file)
@@ -109,10 +109,6 @@ static int m_can_plat_probe(struct platform_device *pdev)
                        ret = irq;
                        goto probe_fail;
                }
-       } else {
-               dev_dbg(mcan_class->dev, "Polling enabled, initialize hrtimer");
-               hrtimer_init(&mcan_class->hrtimer, CLOCK_MONOTONIC,
-                            HRTIMER_MODE_REL_PINNED);
        }
 
        /* message ram could be shared */