]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: qcom: qdsp6: Set error code in q6usb_hw_params()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 15 Apr 2025 10:45:44 +0000 (13:45 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Apr 2025 15:15:17 +0000 (17:15 +0200)
Propagate the error code if q6afe_port_get_from_id() fails.  Don't
return success.

Fixes: 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/Z_442PWaMVoZcbbU@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/qcom/qdsp6/q6usb.c

index 274c251e84dd35cf5bf9bd5a190852b8649042c3..adba0446f3011de1fba5def5532dfb37ffcc4707 100644 (file)
@@ -74,8 +74,10 @@ static int q6usb_hw_params(struct snd_pcm_substream *substream,
                goto out;
 
        q6usb_afe = q6afe_port_get_from_id(cpu_dai->dev, USB_RX);
-       if (IS_ERR(q6usb_afe))
+       if (IS_ERR(q6usb_afe)) {
+               ret = PTR_ERR(q6usb_afe);
                goto out;
+       }
 
        /* Notify audio DSP about the devices being offloaded */
        ret = afe_port_send_usb_dev_param(q6usb_afe, sdev->card_idx,