]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: stmmac: Drop redundant skb_mark_for_recycle() for SKB frags
authorFurong Xu <0x1207@gmail.com>
Fri, 17 Jan 2025 06:28:05 +0000 (14:28 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Jan 2025 20:03:27 +0000 (12:03 -0800)
After commit df542f669307 ("net: stmmac: Switch to zero-copy in
non-XDP RX path"), SKBs are always marked for recycle, it is redundant
to mark SKBs more than once when new frags are appended.

Signed-off-by: Furong Xu <0x1207@gmail.com>
Link: https://patch.msgid.link/20250117062805.192393-1-0x1207@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

index d99ad77a8005ff5f25ffb06d8ebc52e40618a73a..edbf8994455d3730154369954fc934690b8ccfbe 100644 (file)
@@ -5644,9 +5644,6 @@ read_again:
                        skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
                                        buf->page, buf->page_offset, buf1_len,
                                        priv->dma_conf.dma_buf_sz);
-
-                       /* Data payload appended into SKB */
-                       skb_mark_for_recycle(skb);
                        buf->page = NULL;
                }
 
@@ -5656,9 +5653,6 @@ read_again:
                        skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
                                        buf->sec_page, 0, buf2_len,
                                        priv->dma_conf.dma_buf_sz);
-
-                       /* Data payload appended into SKB */
-                       skb_mark_for_recycle(skb);
                        buf->sec_page = NULL;
                }