]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ethernet: remove random_ether_addr()
authorJakub Kicinski <kuba@kernel.org>
Wed, 13 Oct 2021 20:54:50 +0000 (13:54 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 14 Oct 2021 16:24:09 +0000 (09:24 -0700)
random_ether_addr() was the original name of the helper which
was kept for backward compatibility (?) after the rename in
commit 0a4dd594982a ("etherdevice: Rename random_ether_addr
to eth_random_addr").

We have a single random_ether_addr() caller left in tree
while there are 70 callers of eth_random_addr().
Time to drop this define.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20211013205450.328092-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/am65-cpsw-nuss.c
include/linux/etherdevice.h

index 6904bfaa577725949517ca2f87aadbae84b2572f..c092cb61416a180a5ce1d0d28bd163e4a1dab302 100644 (file)
@@ -1918,7 +1918,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
                                                        port->port_id,
                                                        port->slave.mac_addr);
                        if (!is_valid_ether_addr(port->slave.mac_addr)) {
-                               random_ether_addr(port->slave.mac_addr);
+                               eth_random_addr(port->slave.mac_addr);
                                dev_err(dev, "Use random MAC address\n");
                        }
                }
index 76f7ff684cbf6160ac5159df3986651a1edfd348..23681c3d3b8a22278e73ba9de956141347d94095 100644 (file)
@@ -234,8 +234,6 @@ static inline void eth_random_addr(u8 *addr)
        addr[0] |= 0x02;        /* set local assignment bit (IEEE802) */
 }
 
-#define random_ether_addr(addr) eth_random_addr(addr)
-
 /**
  * eth_broadcast_addr - Assign broadcast address
  * @addr: Pointer to a six-byte array containing the Ethernet address