]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: phy: micrel: Introduce function __lan8814_ptp_probe_once
authorHoratiu Vultur <horatiu.vultur@microchip.com>
Tue, 2 Sep 2025 12:18:31 +0000 (14:18 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Sep 2025 00:28:46 +0000 (17:28 -0700)
Introduce the function __lan8814_ptp_probe_once as this function will be
used also by lan8842 driver which has a different number of GPIOs
compared to lan8814. This change doesn't have any functional
changes.

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Link: https://patch.msgid.link/20250902121832.3258544-2-horatiu.vultur@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/micrel.c

index 04bd744920b0d44fd018a8fb4ce4bb2857de7def..9a90818481320df3b0c7dabbcd2628ec08b2e0ac 100644 (file)
@@ -4242,7 +4242,8 @@ static void lan8814_ptp_init(struct phy_device *phydev)
        phydev->default_timestamp = true;
 }
 
-static int lan8814_ptp_probe_once(struct phy_device *phydev)
+static int __lan8814_ptp_probe_once(struct phy_device *phydev, char *pin_name,
+                                   int gpios)
 {
        struct lan8814_shared_priv *shared = phy_package_get_priv(phydev);
 
@@ -4250,18 +4251,18 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev)
        mutex_init(&shared->shared_lock);
 
        shared->pin_config = devm_kmalloc_array(&phydev->mdio.dev,
-                                               LAN8814_PTP_GPIO_NUM,
+                                               gpios,
                                                sizeof(*shared->pin_config),
                                                GFP_KERNEL);
        if (!shared->pin_config)
                return -ENOMEM;
 
-       for (int i = 0; i < LAN8814_PTP_GPIO_NUM; i++) {
+       for (int i = 0; i < gpios; i++) {
                struct ptp_pin_desc *ptp_pin = &shared->pin_config[i];
 
                memset(ptp_pin, 0, sizeof(*ptp_pin));
                snprintf(ptp_pin->name,
-                        sizeof(ptp_pin->name), "lan8814_ptp_pin_%02d", i);
+                        sizeof(ptp_pin->name), "%s_%02d", pin_name, i);
                ptp_pin->index = i;
                ptp_pin->func =  PTP_PF_NONE;
        }
@@ -4271,7 +4272,7 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev)
        shared->ptp_clock_info.max_adj = 31249999;
        shared->ptp_clock_info.n_alarm = 0;
        shared->ptp_clock_info.n_ext_ts = LAN8814_PTP_EXTTS_NUM;
-       shared->ptp_clock_info.n_pins = LAN8814_PTP_GPIO_NUM;
+       shared->ptp_clock_info.n_pins = gpios;
        shared->ptp_clock_info.pps = 0;
        shared->ptp_clock_info.supported_extts_flags = PTP_RISING_EDGE |
                                                       PTP_FALLING_EDGE |
@@ -4318,6 +4319,12 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev)
        return 0;
 }
 
+static int lan8814_ptp_probe_once(struct phy_device *phydev)
+{
+       return __lan8814_ptp_probe_once(phydev, "lan8814_ptp_pin",
+                                       LAN8814_PTP_GPIO_NUM);
+}
+
 static void lan8814_setup_led(struct phy_device *phydev, int val)
 {
        int temp;