smb: client: Return a status code only as a constant in sid_to_id()

Return a status code without storing it in an intermediate variable.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c
index 63b3b1290bed214e04f005d210204382396848df..ce2ebc213a1d91a5939f3e7ee32c087140d89828 100644 (file)
--- a/fs/smb/client/cifsacl.c
+++ b/fs/smb/client/cifsacl.c
@@ -339,7 +339,6 @@ int
 sid_to_id(struct cifs_sb_info *cifs_sb, struct smb_sid *psid,
                struct cifs_fattr *fattr, uint sidtype)
 {
-       int rc = 0;
        struct key *sidkey;
        char *sidstr;
        const struct cred *saved_cred;
@@ -446,12 +445,12 @@ out_revert_creds:
         * fails then we just fall back to using the ctx->linux_uid/linux_gid.
         */
 got_valid_id:
-       rc = 0;
        if (sidtype == SIDOWNER)
                fattr->cf_uid = fuid;
        else
                fattr->cf_gid = fgid;
-       return rc;
+
+       return 0;
 }
 
 int