]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
octeontx2-pf: fix error handling of devlink port in rvu_rep_create()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 17 Dec 2024 05:23:25 +0000 (21:23 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Dec 2024 03:23:51 +0000 (19:23 -0800)
Unregister the devlink port when register_netdev() fails.

Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://patch.msgid.link/20241217052326.1086191-2-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/nic/rep.c

index 9e3fcbae5dee741826cd82638282e48b9109036b..04e08e06f30ff226c0691fddaf61ae5a853adbe0 100644 (file)
@@ -690,6 +690,7 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
                if (err) {
                        NL_SET_ERR_MSG_MOD(extack,
                                           "PFVF representor registration failed");
+                       rvu_rep_devlink_port_unregister(rep);
                        free_netdev(ndev);
                        goto exit;
                }