]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: i2c: mt9m114: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:11 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:22 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/mt9m114.c

index 3f540ca40f3c8d28d9eb05d74714943763afa8d4..37fb8052d20f7f31f3992e3f59e80e6584bc2c70 100644 (file)
@@ -2395,10 +2395,10 @@ static int mt9m114_probe(struct i2c_client *client)
                return ret;
 
        /* Acquire clocks, GPIOs and regulators. */
-       sensor->clk = devm_clk_get(dev, NULL);
+       sensor->clk = devm_v4l2_sensor_clk_get(dev, NULL);
        if (IS_ERR(sensor->clk)) {
-               ret = PTR_ERR(sensor->clk);
-               dev_err_probe(dev, ret, "Failed to get clock\n");
+               ret = dev_err_probe(dev, PTR_ERR(sensor->clk),
+                                   "Failed to get clock\n");
                goto error_ep_free;
        }