]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
btrfs: remove redundant initializations for struct btrfs_tree_parent_check
authorFilipe Manana <fdmanana@suse.com>
Wed, 16 Oct 2024 10:09:26 +0000 (11:09 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 11 Nov 2024 13:34:18 +0000 (14:34 +0100)
It's pointless to initialize the has_first_key field of the stack local
btrfs_tree_parent_check structure at btrfs_tree_parent_check() and at
btrfs_qgroup_trace_subtree() since all fields not explicitly initialized
are zeroed out. In the case of the first function it's a bit odd because
we are assigning 0 and the field is of type bool, however not incorrect
since a 0 is converted to false.

Just remove the explicit initializations due to their redundancy.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c
fs/btrfs/qgroup.c

index 999d5cdad3c000697796d66356538fa8d062a140..4cba6d78e6314884682e6d37e6f16f1a9d192340 100644 (file)
@@ -4286,7 +4286,6 @@ void btrfs_readahead_tree_block(struct btrfs_fs_info *fs_info,
                                u64 bytenr, u64 owner_root, u64 gen, int level)
 {
        struct btrfs_tree_parent_check check = {
-               .has_first_key = 0,
                .level = level,
                .transid = gen
        };
index df76bad8a0674cda3e1e080545ccb853d2bb2a13..a6f92836c9b113e45b0e61e74f06a6c0be0000cf 100644 (file)
@@ -2648,7 +2648,6 @@ int btrfs_qgroup_trace_subtree(struct btrfs_trans_handle *trans,
 
        if (!extent_buffer_uptodate(root_eb)) {
                struct btrfs_tree_parent_check check = {
-                       .has_first_key = false,
                        .transid = root_gen,
                        .level = root_level
                };