net: wwan: Fix bit ops double shift

bit operation helpers such as test_bit, clear_bit, etc take bit
position as parameter and not value. Current usage causes double
shift => BIT(BIT(0)). Fix that in wwan_core and mhi_wwan_ctrl.

Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
index 11475ade4be5d17087f94a0b2df85ab364f27299..416ae6abafb768088b03d098de6a39a37a3e87f3 100644 (file)
--- a/drivers/net/wwan/mhi_wwan_ctrl.c
+++ b/drivers/net/wwan/mhi_wwan_ctrl.c
@@ -7,9 +7,11 @@
 #include <linux/wwan.h>
 
 /* MHI wwan flags */
-#define MHI_WWAN_DL_CAP                BIT(0)
-#define MHI_WWAN_UL_CAP                BIT(1)
-#define MHI_WWAN_RX_REFILL     BIT(2)
+enum mhi_wwan_flags {
+       MHI_WWAN_DL_CAP,
+       MHI_WWAN_UL_CAP,
+       MHI_WWAN_RX_REFILL,
+};
 
 #define MHI_WWAN_MAX_MTU       0x8000
 

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index b618b7937846ab28141935d483654781ab342be6..5be5e1e3534cf17d418ea88861954ccac96b9cdc 100644 (file)
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -26,7 +26,7 @@ static int wwan_major;
 #define to_wwan_port(d) container_of(d, struct wwan_port, dev)
 
 /* WWAN port flags */
-#define WWAN_PORT_TX_OFF       BIT(0)
+#define WWAN_PORT_TX_OFF       0
 
 /**
  * struct wwan_device - The structure that defines a WWAN device