]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: qcom: sm8550: correct MDSS interconnects
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sat, 26 Oct 2024 17:59:40 +0000 (20:59 +0300)
committerBjorn Andersson <andersson@kernel.org>
Thu, 26 Dec 2024 22:43:30 +0000 (16:43 -0600)
SM8550 lists two interconnects for the display subsystem, mdp0-mem
(between MDP and LLCC) and mdp1-mem (between LLCC and EBI, memory).
The second interconnect is a misuse. mdpN-mem paths should be used for
several outboud MDP interconnects rather than the path between LLCC and
memory. This kind of misuse can result in bandwidth underflows, possibly
degrading picture quality as the required memory bandwidth is divided
between all mdpN-mem paths (and LLCC-EBI should not be a part of such
division).

Drop the second path and use direct MDP-EBI path for mdp0-mem until we
support separate MDP-LLCC and LLCC-EBI paths.

Fixes: d7da51db5b81 ("arm64: dts: qcom: sm8550: add display hardware devices")
Cc: stable@kernel.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20241026-fix-sm8x50-mdp-icc-v2-1-fd8ddf755acc@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sm8550.dtsi

index dedd4a2a58f2c89b6e1b12d955da9ef8734604c2..f01af4af1f94f748f34d98be2df986058104bc98 100644 (file)
 
                        power-domains = <&dispcc MDSS_GDSC>;
 
-                       interconnects = <&mmss_noc MASTER_MDP 0 &gem_noc SLAVE_LLCC 0>,
-                                       <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>;
-                       interconnect-names = "mdp0-mem", "mdp1-mem";
+                       interconnects = <&mmss_noc MASTER_MDP 0 &mc_virt SLAVE_EBI1 0>;
+                       interconnect-names = "mdp0-mem";
 
                        iommus = <&apps_smmu 0x1c00 0x2>;