ixgbe: fix incorrect map used in eee linkmode

incorrectly used ixgbe_lp_map in loops intended to populate the
supported and advertised EEE linkmode bitmaps based on ixgbe_ls_map.
This results in incorrect bit setting and potential out-of-bounds
access, since ixgbe_lp_map and ixgbe_ls_map have different sizes
and purposes.

ixgbe_lp_map[i] -> ixgbe_ls_map[i]

Use ixgbe_ls_map for supported and advertised linkmodes, and keep
ixgbe_lp_map usage only for link partner (lp_advertised) mapping.

Fixes: 9356b6db9d05 ("net: ethernet: ixgbe: Convert EEE to use linkmodes")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index 25c3a09ad7f1c8d35b1d37145856c0a6b75c854c..1a2f1bdb91aa3a9c4412bdde1529ab64250e5e4c 100644 (file)
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -3571,13 +3571,13 @@ ixgbe_get_eee_fw(struct ixgbe_adapter *adapter, struct ethtool_keee *edata)
 
        for (i = 0; i < ARRAY_SIZE(ixgbe_ls_map); ++i) {
                if (hw->phy.eee_speeds_supported & ixgbe_ls_map[i].mac_speed)
-                       linkmode_set_bit(ixgbe_lp_map[i].link_mode,
+                       linkmode_set_bit(ixgbe_ls_map[i].link_mode,
                                         edata->supported);
        }
 
        for (i = 0; i < ARRAY_SIZE(ixgbe_ls_map); ++i) {
                if (hw->phy.eee_speeds_advertised & ixgbe_ls_map[i].mac_speed)
-                       linkmode_set_bit(ixgbe_lp_map[i].link_mode,
+                       linkmode_set_bit(ixgbe_ls_map[i].link_mode,
                                         edata->advertised);
        }