]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
samples: rust: pci: take advantage of Devres::access()
authorDanilo Krummrich <dakr@kernel.org>
Mon, 28 Apr 2025 14:00:29 +0000 (16:00 +0200)
committerDanilo Krummrich <dakr@kernel.org>
Sun, 4 May 2025 15:54:08 +0000 (17:54 +0200)
For the I/O operations executed from the probe() method, take advantage
of Devres::access(), avoiding the atomic check and RCU read lock required
otherwise entirely.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Link: https://lore.kernel.org/r/20250428140137.468709-4-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
samples/rust/rust_driver_pci.rs

index 9ce3a7323a1632e08f833a14c3f49a4218e9a5e6..15147e4401b2c5002a9d91f1668fb74e20c3431f 100644 (file)
@@ -83,12 +83,12 @@ impl pci::Driver for SampleDriver {
             GFP_KERNEL,
         )?;
 
-        let res = drvdata
-            .bar
-            .try_access_with(|b| Self::testdev(info, b))
-            .ok_or(ENXIO)??;
-
-        dev_info!(pdev.as_ref(), "pci-testdev data-match count: {}\n", res);
+        let bar = drvdata.bar.access(pdev.as_ref())?;
+        dev_info!(
+            pdev.as_ref(),
+            "pci-testdev data-match count: {}\n",
+            Self::testdev(info, bar)?
+        );
 
         Ok(drvdata.into())
     }