]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/display: use vmalloc for struct dc_state
authorAlex Deucher <alexander.deucher@amd.com>
Wed, 26 Jun 2024 21:35:41 +0000 (17:35 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 1 Jul 2024 20:06:52 +0000 (16:06 -0400)
This is a big structure so use vmalloc as malloc can
fail when there is memory pressure.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3454
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c

index 5d4f831b1e55563d4c208a9aea9485e905c24e0b..5442da90f508f673e162b5f7ca41c7ec9f04b472 100644 (file)
@@ -23,6 +23,7 @@
  *
  */
 
+#include <linux/vmalloc.h>
 #include <drm/display/drm_dp_helper.h>
 #include <drm/display/drm_dp_mst_helper.h>
 #include <drm/drm_atomic.h>
@@ -1491,9 +1492,10 @@ int pre_validate_dsc(struct drm_atomic_state *state,
         * from dm_state->context.
         */
 
-       local_dc_state = kmemdup(dm_state->context, sizeof(struct dc_state), GFP_KERNEL);
+       local_dc_state = vmalloc(sizeof(struct dc_state));
        if (!local_dc_state)
                return -ENOMEM;
+       memcpy(local_dc_state, dm_state->context, sizeof(struct dc_state));
 
        for (i = 0; i < local_dc_state->stream_count; i++) {
                struct dc_stream_state *stream = dm_state->context->streams[i];
@@ -1563,7 +1565,7 @@ clean_exit:
                        dc_stream_release(local_dc_state->streams[i]);
        }
 
-       kfree(local_dc_state);
+       vfree(local_dc_state);
 
        return ret;
 }