bonding: update LACP activity flag after setting lacp_active

The port's actor_oper_port_state activity flag should be updated immediately
after changing the lacp_active option to reflect the current mode correctly.

Fixes: 3a755cd8b7c6 ("bonding: add new option lacp_active")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20250815062000.22220-2-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 2fca8e84ab100be2e3c1dc4f62d77026820d5581..414fecfd2a0ee1e51145e16f24be8f6d682a9fc7 100644 (file)
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -2883,6 +2883,31 @@ void bond_3ad_update_lacp_rate(struct bonding *bond)
        spin_unlock_bh(&bond->mode_lock);
 }
 
+/**
+ * bond_3ad_update_lacp_active - change the lacp active
+ * @bond: bonding struct
+ *
+ * Update actor_oper_port_state when lacp_active is modified.
+ */
+void bond_3ad_update_lacp_active(struct bonding *bond)
+{
+       struct port *port = NULL;
+       struct list_head *iter;
+       struct slave *slave;
+       int lacp_active;
+
+       lacp_active = bond->params.lacp_active;
+       spin_lock_bh(&bond->mode_lock);
+       bond_for_each_slave(bond, slave, iter) {
+               port = &(SLAVE_AD_INFO(slave)->port);
+               if (lacp_active)
+                       port->actor_oper_port_state |= LACP_STATE_LACP_ACTIVITY;
+               else
+                       port->actor_oper_port_state &= ~LACP_STATE_LACP_ACTIVITY;
+       }
+       spin_unlock_bh(&bond->mode_lock);
+}
+
 size_t bond_3ad_stats_size(void)
 {
        return nla_total_size_64bit(sizeof(u64)) + /* BOND_3AD_STAT_LACPDU_RX */

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 1d639a3be6bac8704cc54653a64c67a5de64e1e0..3b6f815c55ffaa1ce08cecace161adb235a99fa9 100644 (file)
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -1660,6 +1660,7 @@ static int bond_option_lacp_active_set(struct bonding *bond,
        netdev_dbg(bond->dev, "Setting LACP active to %s (%llu)\n",
                   newval->string, newval->value);
        bond->params.lacp_active = newval->value;
+       bond_3ad_update_lacp_active(bond);
 
        return 0;
 }

diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h
index 2053cd8e788a73cf7218519638d27c69c8eae37d..dba369a2cf27ef6258d029ded76299eb126e759f 100644 (file)
--- a/include/net/bond_3ad.h
+++ b/include/net/bond_3ad.h
@@ -307,6 +307,7 @@ int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
                         struct slave *slave);
 int bond_3ad_set_carrier(struct bonding *bond);
 void bond_3ad_update_lacp_rate(struct bonding *bond);
+void bond_3ad_update_lacp_active(struct bonding *bond);
 void bond_3ad_update_ad_actor_settings(struct bonding *bond);
 int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats *stats);
 size_t bond_3ad_stats_size(void);