]> www.infradead.org Git - users/hch/xfsprogs.git/commitdiff
xfs: remove the redundant xfs_alloc_log_agf
authorLong Li <leo.lilong@huawei.com>
Mon, 25 Nov 2024 21:14:11 +0000 (13:14 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 28 Nov 2024 02:33:08 +0000 (18:33 -0800)
Source kernel commit: 8b9b261594d8ef218ef4d0e732dad153f82aab49

There are two invocations of xfs_alloc_log_agf in xfs_alloc_put_freelist.
The AGF does not change between the two calls. Although this does not pose
any practical problems, it seems like a small mistake. Therefore, fix it
by removing the first xfs_alloc_log_agf invocation.

Signed-off-by: Long Li <leo.lilong@huawei.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
libxfs/xfs_alloc.c

index f0635b17f18548d97cb097f7ae46d80f4f32b2eb..355f8ef1a872d34dc8b0504907c69904e0df72fd 100644 (file)
@@ -3152,8 +3152,6 @@ xfs_alloc_put_freelist(
                logflags |= XFS_AGF_BTREEBLKS;
        }
 
-       xfs_alloc_log_agf(tp, agbp, logflags);
-
        ASSERT(be32_to_cpu(agf->agf_flcount) <= xfs_agfl_size(mp));
 
        agfl_bno = xfs_buf_to_agfl_bno(agflbp);