]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ARM: sa1100: make match function take a const pointer
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Jul 2024 09:39:17 +0000 (11:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Jul 2024 11:47:20 +0000 (13:47 +0200)
In commit d69d80484598 ("driver core: have match() callback in struct
bus_type take a const *"), the match callback for busses was changed to
take a const pointer to struct device_driver.  Unfortunately I missed
fixing up the sa1111 code, and was only noticed after-the-fact by the
kernel test robot.  Resolve this issue by properly changing the
sa111_match() function.

Cc: Russell King <linux@armlinux.org.uk>
Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20240712093916.2121096-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/common/sa1111.c
arch/arm/include/asm/hardware/sa1111.h

index 1fbd7363cf118144b5d92595dbeecd382ec9698e..550978dc3c50ea69082ad941aa6ef57a15f0eb32 100644 (file)
@@ -1339,10 +1339,10 @@ EXPORT_SYMBOL_GPL(sa1111_get_irq);
  *     We model this as a regular bus type, and hang devices directly
  *     off this.
  */
-static int sa1111_match(struct device *_dev, struct device_driver *_drv)
+static int sa1111_match(struct device *_dev, const struct device_driver *_drv)
 {
        struct sa1111_dev *dev = to_sa1111_device(_dev);
-       struct sa1111_driver *drv = SA1111_DRV(_drv);
+       const struct sa1111_driver *drv = SA1111_DRV(_drv);
 
        return !!(dev->devid & drv->devid);
 }
index d8c6f8a99dfa157f0a479d6e9acdfc9d11841cac..a815f39b4243904787ab180e87f7418db70d56dc 100644 (file)
@@ -404,7 +404,7 @@ struct sa1111_driver {
        void (*remove)(struct sa1111_dev *);
 };
 
-#define SA1111_DRV(_d) container_of((_d), struct sa1111_driver, drv)
+#define SA1111_DRV(_d) container_of_const((_d), struct sa1111_driver, drv)
 
 #define SA1111_DRIVER_NAME(_sadev) ((_sadev)->dev.driver->name)