]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
iomap: Minor code simplification in iomap_dio_bio_iter()
authorJohn Garry <john.g.garry@oracle.com>
Mon, 24 Feb 2025 15:45:38 +0000 (15:45 +0000)
committerChristian Brauner <brauner@kernel.org>
Tue, 25 Feb 2025 10:55:26 +0000 (11:55 +0100)
Combine 'else' and 'if' conditional statements onto a single line and drop
unrequired braces, as is standard coding style.

The code had been like this since commit c3b0e880bbfa ("iomap: support
REQ_OP_ZONE_APPEND").

Signed-off-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20250224154538.548028-1-john.g.garry@oracle.com
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/iomap/direct-io.c

index b521eb15759e8ba81f36b08d88a2e37702c70901..0e47da82b0c247274e11645441a5d4b38a98676f 100644 (file)
@@ -427,12 +427,10 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
                        bio_put(bio);
                        goto zero_tail;
                }
-               if (dio->flags & IOMAP_DIO_WRITE) {
+               if (dio->flags & IOMAP_DIO_WRITE)
                        task_io_account_write(n);
-               } else {
-                       if (dio->flags & IOMAP_DIO_DIRTY)
-                               bio_set_pages_dirty(bio);
-               }
+               else if (dio->flags & IOMAP_DIO_DIRTY)
+                       bio_set_pages_dirty(bio);
 
                dio->size += n;
                copied += n;