drm/sched: Fix static checker warning for potential NULL ptr

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1558533443-7795-1-git-send-email-andrey.grodzovsky@amd.com

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index cf596fc0355b1df51bf50b7d32646d38e1c70bc5..49e7d0780414bfec334b2d43a4f9ae061ef88796 100644 (file)
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -286,16 +286,17 @@ static void drm_sched_job_timedout(struct work_struct *work)
        job = list_first_entry_or_null(&sched->ring_mirror_list,
                                       struct drm_sched_job, node);
 
-       if (job)
+       if (job) {
                job->sched->ops->timedout_job(job);
 
-       /*
-        * Guilty job did complete and hence needs to be manually removed
-        * See drm_sched_stop doc.
-        */
-       if (sched->free_guilty) {
-               job->sched->ops->free_job(job);
-               sched->free_guilty = false;
+               /*
+                * Guilty job did complete and hence needs to be manually removed
+                * See drm_sched_stop doc.
+                */
+               if (sched->free_guilty) {
+                       job->sched->ops->free_job(job);
+                       sched->free_guilty = false;
+               }
        }
 
        spin_lock_irqsave(&sched->job_list_lock, flags);