]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ksmbd: return STATUS_NOT_SUPPORTED on unsupported smb2.0 dialect
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 21 Mar 2023 06:36:40 +0000 (15:36 +0900)
committerSteve French <stfrench@microsoft.com>
Wed, 22 Mar 2023 21:38:33 +0000 (16:38 -0500)
ksmbd returned "Input/output error" when mounting with vers=2.0 to
ksmbd. It should return STATUS_NOT_SUPPORTED on unsupported smb2.0
dialect.

Cc: stable@vger.kernel.org
Reported-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/smb_common.c

index fa2b54df6ee6ff2aad4da4f3090010b26a863c63..079c9e76818d8065d074084c4ac0a68f4fac2f0e 100644 (file)
@@ -434,7 +434,7 @@ int ksmbd_extract_shortname(struct ksmbd_conn *conn, const char *longname,
 
 static int __smb2_negotiate(struct ksmbd_conn *conn)
 {
-       return (conn->dialect >= SMB21_PROT_ID &&
+       return (conn->dialect >= SMB20_PROT_ID &&
                conn->dialect <= SMB311_PROT_ID);
 }
 
@@ -465,7 +465,7 @@ int ksmbd_smb_negotiate_common(struct ksmbd_work *work, unsigned int command)
                }
        }
 
-       if (command == SMB2_NEGOTIATE_HE && __smb2_negotiate(conn)) {
+       if (command == SMB2_NEGOTIATE_HE) {
                ret = smb2_handle_negotiate(work);
                init_smb2_neg_rsp(work);
                return ret;