]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
aio-wait: switch to smp_mb__after_rmw()
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 3 Mar 2023 10:03:52 +0000 (11:03 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 7 Mar 2023 11:39:50 +0000 (12:39 +0100)
The barrier comes after an atomic increment, so it is enough to use
smp_mb__after_rmw(); this avoids a double barrier on x86 systems.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/block/aio-wait.h

index dd9a7f6461ef20e21bf1662ba5f8f3916d8862cb..da13357bb8cfb287b2c64d29362ac3353b4f3316 100644 (file)
@@ -85,7 +85,7 @@ extern AioWait global_aio_wait;
     /* Increment wait_->num_waiters before evaluating cond. */     \
     qatomic_inc(&wait_->num_waiters);                              \
     /* Paired with smp_mb in aio_wait_kick(). */                   \
-    smp_mb();                                                      \
+    smp_mb__after_rmw();                                           \
     if (ctx_ && in_aio_context_home_thread(ctx_)) {                \
         while ((cond)) {                                           \
             aio_poll(ctx_, true);                                  \