net/mlx5e: Use extack in get module eeprom by page callback

In case of errors in get module eeprom by page, reflect it through
extack instead of a dmesg print.
While at it, make the messages more human friendly.

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20240808055927.2059700-10-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
index c14a5542ae9c90eb632685960bda07e9da2936d6..56bdb4d07b7adf1d8b8e70cc63b7d946b5df5733 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
@@ -2015,8 +2015,10 @@ static int mlx5e_get_module_eeprom_by_page(struct net_device *netdev,
                if (size_read == -EINVAL)
                        return -EINVAL;
                if (size_read < 0) {
-                       netdev_err(priv->netdev, "%s: mlx5_query_module_eeprom_by_page failed:0x%x\n",
-                                  __func__, size_read);
+                       NL_SET_ERR_MSG_FMT_MOD(
+                               extack,
+                               "Query module eeprom by page failed, read %u bytes, err %d\n",
+                               i, size_read);
                        return i;
                }