media: venus: venus_helper_get_bufreq(): req is never NULL

Fix a smatch error:

drivers/media/platform/qcom/venus/helpers.c: drivers/media/platform/qcom/venus/helpers.c:678 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 674)

After checking how venus_helper_get_bufreq() is called it is clear that
req is never NULL, so just drop the checks.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
index 5c1104379c4910046b89938632f5869a75740f51..60de4200375dddd317ae4c3650d4b0e467e92fa8 100644 (file)
--- a/drivers/media/platform/qcom/venus/helpers.c
+++ b/drivers/media/platform/qcom/venus/helpers.c
@@ -671,8 +671,7 @@ int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
        unsigned int i;
        int ret;
 
-       if (req)
-               memset(req, 0, sizeof(*req));
+       memset(req, 0, sizeof(*req));
 
        if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
                req->count_min = inst->fw_min_cnt;
@@ -694,8 +693,7 @@ int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
                if (hprop.bufreq[i].type != type)
                        continue;
 
-               if (req)
-                       memcpy(req, &hprop.bufreq[i], sizeof(*req));
+               memcpy(req, &hprop.bufreq[i], sizeof(*req));
                ret = 0;
                break;
        }